-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base64 Encoded Icon cannot read property width of undefined #336
Comments
Please send a pull request. |
Sorry for the late reply. I was away for a while. The thing is, I used your own code. I just replaced icon with Base64 icon. In my opinion you can test it with your existing project. |
Hmm, that's not welcome answer. Open Source Code is for open to contribute by everyone. Error report, claiming, etc, .... well, better than nothing, but you take other person's time. Most of the case, you take the developer's time. Then open source library would die. So, word like "test your self!" means you kill the open source software. If you like/love the software (not only this plugin), please contribute no matter what any formation. |
Hey, |
Any update on this issues? |
Unfortunately there is no enough time to work on this (not only this, but all others) at all. |
Thanks for your honesty. Ionic links this plugin in their website officially and they didn't support it actively ? |
ionic/google-maps plugin is kind of different history than others. This plugin is a wrapper plugin for cordova-plugin-googlemaps. Then this plugin is spin out from the control under the ionic team, and I maintenance this plugin directly. Since all source code is open, you can debug the code by yourself. |
I have the same error appearing in my app but it seemed to work so I was not too worried about it. I even did not know it was caused by the base64-encoded icon but at least I'm aware now. @Binitronics apart from the error in the console are you experiencing any issues? |
The only issue I encountered is the error on the console. The icon is drawn as expected. |
Just one opinion. I have seen that people encounter some issues and you askes them to share their project folder (on github for example). You said "Unfortunately there is no enough time to work on this (not only this, but all others) at all." If you don't have any time, it is probably a good idea to stop asking people to share their project. Even, it is good to inform users that this plugin is not actively maintained before they spend their time (could be in your readme file). |
I have been using this plugin for 2 years and it is excellent I appreciate your time and effort @wf9a5m75 This error appeared in the latest version that is in git since I have other maps working without problems, check your code fragment, simply define the width of your icon and you will no longer see the undefined error in console, I hope it helps you, excuse my spelling excellent day @Binitronics
|
I'm submitting a ... (check one with "x")
If you choose 'problem or bug report', please select OS: (check one with "x")
cordova information: (run
$> cordova plugin list
)Current behavior:
Adding a marker using Base64 format produces an error. The marker is shown on the map as expected but the error mentioned above is produced.
Expected behavior:
The marker should be draw on the map with out producing error.
Screen capture or video record:
Related code, data or error log (please format your code or data):
The text was updated successfully, but these errors were encountered: