chore(angular): test app support for angular 15 #26313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
commented
Nov 17, 2022
| "@ionic/angular": "^6.1.15", | ||
| "@ionic/angular-server": "^6.1.15", | ||
| "@nguniversal/express-engine": "^14.0.3", | ||
| "angular-in-memory-web-api": "^0.11.0", |
Contributor
Author
There was a problem hiding this comment.
This dependency was unused and was causing problems. I'll have a follow-up PR to remove it from the other test apps (it is unused in all).
liamdebeasi
approved these changes
Nov 17, 2022
averyjohnston
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Angular test app targets the RC version of Angular 15.
Github action for testing Angular app installs legacy peer dependencies.
Issue URL: Internal
What is the new behavior?
^15.0.0vs. the RCDoes this introduce a breaking change?
Other information