Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 9, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26249

What is the new behavior?

  • Action sheet icons on MD no longer have bottom padding

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 9, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 9, 2022 20:48
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 9, 2022 20:48
@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Nov 9, 2022

The pixel diffs are too small for our current config to detect, so I manually removed the relevant screenshots and regenerated them. I accidentally regenerated a few iOS screenshots which is why you see a some added here.

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

The trash icon is the only asset that looks "strange". It isn't visually centered to the content. This is likely due to the height of the icon asset compared to the others.

@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Nov 9, 2022

Actually it looks like the text is not centered. Let me take a closer look. (It wasn't centered prior to this PR, but maybe the 4px was there in an attempt to account for this) Never mind yes it is -- the text extended down a pixel lower than I originally thought.

@liamdebeasi liamdebeasi merged commit 627d654 into main Nov 11, 2022
@liamdebeasi liamdebeasi deleted the FW-2780 branch November 11, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Action sheet icon is not centered on MD

5 participants