-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(overlays): presenting an overlay does not create nested elements #26154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should we be reflecting the |
averyjohnston
approved these changes
Oct 21, 2022
liamdebeasi
suggested changes
Oct 27, 2022
core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts
Outdated
Show resolved
Hide resolved
liamdebeasi
approved these changes
Nov 2, 2022
Contributor
liamdebeasi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When overlays are presented without a user defined component, the overlay will continue to create elements at the root of the overlay and append the contents of the teleported component inside of it. This results in scenarios where in implementations like
ion-datetime-buttonwith anion-modal, theion-modalwill create a nested DOM tree of.ion-pageelements.Issue URL: #26117
What is the new behavior?
.ion-pageelementsDoes this introduce a breaking change?
Other information
Dev-build:
6.3.3-dev.11666207854.1e96b6a8This is the same fix that we landed on for this feature: #26153, but since that is targeted for v7, it would be great to resolve this specific bug for v6.