feat(loading): isOpen presents and dismisses loading overlay #26067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
commented
Oct 3, 2022
| */ | ||
| "htmlAttributes"?: LoadingAttributes; | ||
| /** | ||
| * If `true`, the loading indicator will open. If `false`, the loading indicator will close. Use this if you need finer grained control over presentation, otherwise just use the loadingController or the `trigger` property. Note: `isOpen` will not automatically be set back to `false` when the loading indicator dismisses. You will need to do that in your code. |
Contributor
Author
There was a problem hiding this comment.
trigger is not supported as of this pull request, but I opted it for aligning the documentation with ion-modal now vs. risking forgetting to update this later. When FW-2334 lands in feature-7.0, this will be accurate.
sean-perkins
commented
Oct 3, 2022
sean-perkins
commented
Oct 3, 2022
github-actions
bot
added
package: react
13 tasks
averyjohnston
approved these changes
Oct 7, 2022
liamdebeasi
reviewed
Oct 10, 2022
liamdebeasi
suggested changes
Oct 13, 2022
liamdebeasi
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-loadingcannot be used inline.Issue URL: Internal
What is the new behavior?
ion-loadingsupportsisOpenproperty to present and dismiss the loading indicatorDoes this introduce a breaking change?
Other information