Skip to content

ci(release): purge JSDelivr cache on release #25687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jul 27, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

JSDeliver caches resources for ~7 days: https://github.com/jsdelivr/jsdelivr#caching. This means that for up to 7 days after a release, the component playgrounds load an outdated version of Ionic. This is problematic with feature releases where the playgrounds for the new features will not work as an old version of Ionic is loaded.

What is the new behavior?

  • On successful release, a request will be made to JSDeliver to purge the JS and CSS files for the 6 and latest tags for Ionic Core.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi marked this pull request as ready for review July 27, 2022 19:56
@liamdebeasi liamdebeasi requested a review from a team July 27, 2022 19:56
Co-authored-by: Sean Perkins <sean@ionic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants