Skip to content

feat(vue): support autoMountComponent #25538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 28, 2022
Merged

feat(vue): support autoMountComponent #25538

merged 8 commits into from
Jun 28, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 27, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: Internal ticket.

What is the new behavior?

  • Adds support for autoMountComponent to Ionic Vue.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Jun 27, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review June 27, 2022 16:55
@liamdebeasi liamdebeasi requested a review from a team June 27, 2022 16:55
Base automatically changed from 1514-base to FW-1514 June 28, 2022 15:57
@liamdebeasi liamdebeasi merged commit 9a11077 into FW-1514 Jun 28, 2022
@liamdebeasi liamdebeasi deleted the 1514-vue branch June 28, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants