fix(docusaurus): support diff code blocks #4156 #4158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soundproofboot is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
…d, deleted class only for diff blocks
brandyscarney
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
approved these changes
Jun 23, 2025
thetaPC
requested changes
Jun 26, 2025
| @@ -324,7 +324,7 @@ module.exports = { | |||
| prism: { | |||
| theme: { plain: {}, styles: [] }, | |||
| // https://github.com/FormidableLabs/prism-react-renderer/blob/e6d323332b0363a633407fabab47b608088e3a4d/packages/generate-prism-languages/index.ts#L9-L25 | |||
There was a problem hiding this comment.
Let's update this comment:
Suggested change
| // https://github.com/FormidableLabs/prism-react-renderer/blob/e6d323332b0363a633407fabab47b608088e3a4d/packages/generate-prism-languages/index.ts#L9-L25 | |
| // Prism provides a [default list of languages](https://github.com/FormidableLabs/prism-react-renderer/blob/e1c83a468b05df7f452b3ad7e4ae5ab874574d4e/packages/generate-prism-languages/index.ts#L9-L26). | |
| // A list of [additional languages](https://prismjs.com/#supported-languages) that are supported can be found at their website. |
| @@ -149,7 +148,8 @@ pre[class*='language-'] { | |||
| .token.attr-value, | |||
| .language-css .token.string, | |||
| .style .token.string, | |||
| .token.variable { | |||
| .token.variable, | |||
| .token.inserted { | |||
There was a problem hiding this comment.
Let's add a comment of what .token.inserted does so it's easier for us to debug. There's a lot of old code in this repo that we're not sure what's needed or not. By providing comments like these, we can start to figure out what is important.
Suggested change
| .token.inserted { | |
| // Code additions (indicated by a leading '+') within a diff. | |
| .token.inserted { |
Do the same for .token.deleted:
// Code removals (indicated by a leading '-') within a diff.
.token.deleted {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4156
Changes
.token.insertedselector to greenish #42b983 block after verifying.token.insertedand.token.deletedwill only select lines in diff blocksScreenshot
Screenshot from docs/angular/build-options