refactor(): deprecate rollup, closure, and babili support

Author: danbucholtz

src/babili.spec.ts

@@ -1,39 +1,11 @@
 import * as bundle from './bundle';
-import * as rollup from './rollup';
 import * as webpack from './webpack';
 import * as Constants from './util/constants';
 import { ChangedFile } from './util/interfaces';
 
 describe('bundle task', () => {
 
   describe('bundle', () => {
-    it('should return the value rollup task returns', () => {
-      // arrange
-      spyOn(rollup, rollup.rollup.name).and.returnValue(Promise.resolve());
-      const context = { bundler: Constants.BUNDLER_ROLLUP};
-
-      // act
-      return bundle.bundle(context).then(() => {
-        // assert
-        expect(rollup.rollup).toHaveBeenCalled();
-      });
-    });
-
-    it('should throw when rollup throws', () => {
-      const errorText = 'simulating an error';
-      // arrange
-      spyOn(rollup, rollup.rollup.name).and.returnValue(Promise.reject(new Error(errorText)));
-      const context = { bundler: Constants.BUNDLER_ROLLUP};
-
-      // act
-      return bundle.bundle(context).then(() => {
-        throw new Error('Should never happen');
-      }).catch(err => {
-        // assert
-        expect(rollup.rollup).toHaveBeenCalled();
-        expect(err.message).toBe(errorText);
-      });
-    });
 
     it('should return the value webpack task returns', () => {
       // arrange
@@ -47,7 +19,7 @@ describe('bundle task', () => {
       });
     });
 
-    it('should throw when rollup throws', () => {
+    it('should throw when webpack throws', () => {
       const errorText = 'simulating an error';
       // arrange
       spyOn(webpack, webpack.webpack.name).and.returnValue(Promise.reject(new Error(errorText)));
@@ -65,35 +37,6 @@ describe('bundle task', () => {
   });
 
   describe('bundleUpdate', () => {
-    it('should return the value rollup returns', () => {
-      // arrange
-      spyOn(rollup, rollup.rollupUpdate.name).and.returnValue(Promise.resolve());
-      const context = { bundler: Constants.BUNDLER_ROLLUP};
-      const changedFiles: ChangedFile[] = [];
-
-      // act
-      return bundle.bundleUpdate(changedFiles, context).then(() => {
-        // assert
-        expect(rollup.rollupUpdate).toHaveBeenCalledWith(changedFiles, context);
-      });
-    });
-
-    it('should throw when rollup throws', () => {
-      const errorText = 'simulating an error';
-      // arrange
-      spyOn(rollup, rollup.rollupUpdate.name).and.returnValue(Promise.reject(new Error(errorText)));
-      const context = { bundler: Constants.BUNDLER_ROLLUP};
-      const changedFiles: ChangedFile[] = [];
-
-      // act
-      return bundle.bundleUpdate(changedFiles, context).then(() => {
-        throw new Error('Should never happen');
-      }).catch(err => {
-        // assert
-        expect(rollup.rollupUpdate).toHaveBeenCalled();
-        expect(err.message).toBe(errorText);
-      });
-    });
 
     it('should return the value webpack returns', () => {
       // arrange
@@ -132,20 +75,6 @@ describe('bundle task', () => {
   });
 
   describe('buildJsSourceMaps', () => {
-    it('should get the value from the rollup config', () => {
-      // arrange
-      const config = {
-        sourceMap: true
-      };
-      spyOn(rollup, rollup.getRollupConfig.name).and.returnValue(config);
-      const context = { bundler: Constants.BUNDLER_ROLLUP};
-      // act
-      const result = bundle.buildJsSourceMaps(context);
-
-      // assert
-      expect(rollup.getRollupConfig).toHaveBeenCalledWith(context, null);
-      expect(result).toEqual(config.sourceMap);
-    });
 
     it('should get false when devtool is null for webpack', () => {
       // arrange
@@ -175,21 +104,6 @@ describe('bundle task', () => {
   });
 
   describe('getJsOutputDest', () => {
-    it('should get the value from rollup', () => {
-      // arrange
-      const config = { };
-      const returnValue = 'someString';
-      spyOn(rollup, rollup.getRollupConfig.name).and.returnValue(config);
-      spyOn(rollup, rollup.getOutputDest.name).and.returnValue(returnValue);
-      const context = { bundler: Constants.BUNDLER_ROLLUP};
-      // act
-      const result = bundle.getJsOutputDest(context);
-
-      // assert
-      expect(rollup.getRollupConfig).toHaveBeenCalledWith(context, null);
-      expect(rollup.getOutputDest).toHaveBeenCalledWith(context, config);
-      expect(result).toEqual(returnValue);
-    });
 
     it('should get the value from webpack', () => {
       // arrange

src/babili.ts

@@ -1,7 +1,6 @@
 import { BuildContext, ChangedFile } from './util/interfaces';
 import { BuildError, IgnorableError } from './util/errors';
 import * as Constants from './util/constants';
-import { rollup, rollupUpdate, getRollupConfig, getOutputDest as rollupGetOutputDest } from './rollup';
 import { webpack, webpackUpdate, getWebpackConfig, getOutputDest as webpackGetOutputDest } from './webpack';
 
 
@@ -14,22 +13,11 @@ export function bundle(context: BuildContext, configFile?: string) {
 
 
 function bundleWorker(context: BuildContext, configFile: string) {
-  if (context.bundler === Constants.BUNDLER_ROLLUP) {
-    return rollup(context, configFile);
-  }
-
   return webpack(context, configFile);
 }
 
 
 export function bundleUpdate(changedFiles: ChangedFile[], context: BuildContext) {
-  if (context.bundler === Constants.BUNDLER_ROLLUP) {
-    return rollupUpdate(changedFiles, context)
-      .catch(err => {
-        throw new BuildError(err);
-      });
-  }
-
   return webpackUpdate(changedFiles, context)
     .catch(err => {
       if (err instanceof IgnorableError) {
@@ -41,21 +29,11 @@ export function bundleUpdate(changedFiles: ChangedFile[], context: BuildContext)
 
 
 export function buildJsSourceMaps(context: BuildContext) {
-  if (context.bundler === Constants.BUNDLER_ROLLUP) {
-    const rollupConfig = getRollupConfig(context, null);
-    return rollupConfig.sourceMap;
-  }
-
   const webpackConfig = getWebpackConfig(context, null);
   return !!(webpackConfig.devtool && webpackConfig.devtool.length > 0);
 }
 
 
 export function getJsOutputDest(context: BuildContext) {
-  if (context.bundler === Constants.BUNDLER_ROLLUP) {
-    const rollupConfig = getRollupConfig(context, null);
-    return rollupGetOutputDest(context, rollupConfig);
-  }
-
   return webpackGetOutputDest(context);
 }