Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Commit 7b69fd6

Browse files
committed
Take options from cli, including option to not run resources during package
1 parent 90b511d commit 7b69fd6

File tree

1 file changed

+21
-15
lines changed

1 file changed

+21
-15
lines changed

lib/package.js

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,25 +36,25 @@ events.on('package-start', function() {
3636

3737
});
3838

39-
Package.buildAndroidDebug = function(appDirectory, jar, appId) {
39+
Package.buildAndroidDebug = function(appDirectory, jar, appId, options) {
4040
return build(appDirectory, jar, appId, undefined, {
4141
platform: 'android',
4242
build_mode: 'debug'
43-
});
43+
}, options);
4444
};
4545

46-
Package.buildAndroidRelease = function(appDirectory, jar, appId, profile) {
46+
Package.buildAndroidRelease = function(appDirectory, jar, appId, profile, options) {
4747
return build(appDirectory, jar, appId, profile, {
4848
platform: 'android',
4949
build_mode: 'release'
50-
});
50+
}, options);
5151
};
5252

53-
Package.buildIOS = function(appDirectory, jar, appId, profile, buildMode) {
53+
Package.buildIOS = function(appDirectory, jar, appId, profile, buildMode, options) {
5454
return build(appDirectory, jar, appId, profile, {
5555
platform: 'ios',
5656
build_mode: buildMode
57-
});
57+
}, options);
5858
};
5959

6060
Package.listBuilds = function(appId, jar) {
@@ -167,7 +167,7 @@ Package.determineFileExtensionByPlatform = function(platform) {
167167
throw new Error('Unknown platform: ' + platform);
168168
}
169169

170-
function build(appDirectory, jar, appId, profileTag, formDataExtra) {
170+
function build(appDirectory, jar, appId, profileTag, formDataExtra, options) {
171171
events.emit('package-start');
172172

173173
var uploadUrl,
@@ -204,18 +204,22 @@ function build(appDirectory, jar, appId, profileTag, formDataExtra) {
204204
uploadUrl = upload.url;
205205
})
206206
.then(function(url) {
207-
return IonicResources.generate(appDirectory, { default: true, platforms: ['all'] });
207+
if (typeof options.noresources === 'undefined') {
208+
return IonicResources.generate(appDirectory, { default: true, platforms: ['all'] });
209+
}
208210
})
209211
.then(null, function(err) {
210212
if (err !== 'RESOURCES_EXISTS') {
211213
return Q.reject(err);
212214
}
213215
})
214216
.then(function(url) {
215-
events.emit('package-post-default-resources');
216-
logging.logger.info('Preparing your resources...');
217-
events.emit('package-pre-prepare-resources');
218-
return IonicResources.generate(appDirectory, { platforms: ['all'] });
217+
if (typeof options.noresources === 'undefined') {
218+
events.emit('package-post-default-resources');
219+
logging.logger.info('Preparing your resources...');
220+
events.emit('package-pre-prepare-resources');
221+
return IonicResources.generate(appDirectory, { platforms: ['all'] });
222+
}
219223
})
220224
.then(function() {
221225
var q = Q.defer(),
@@ -280,7 +284,7 @@ function build(appDirectory, jar, appId, profileTag, formDataExtra) {
280284
.then(function(body) {
281285
projectZipId = body.data.id;
282286

283-
logging.logger.info("Uploading your resources to Ionic...");
287+
logging.logger.info("Uploading your project to Ionic...");
284288

285289
return uploadProjectZip(
286290
body.data.presigned_post.url,
@@ -304,14 +308,16 @@ function build(appDirectory, jar, appId, profileTag, formDataExtra) {
304308
return sendToPackageService(appId, jar, _.extend(formData, formDataExtra));
305309
})
306310
.then(function(body) {
311+
var buildId = body.data.id;
312+
307313
events.emit('package-post-submit');
308314
logging.logger.info("Your app has been successfully submitted to Ionic Package!".green);
309-
logging.logger.info('Build ID:', body.data.id);
315+
logging.logger.info('Build ID:', buildId);
310316
logging.logger.info("We are now packaging your app.");
311317

312318
fs.unlinkSync(projectZipPath);
313319

314-
return body.data.id;
320+
return buildId;
315321
});
316322
};
317323

0 commit comments

Comments
 (0)