feat(): support ios/md attribute of ion-icon #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdlabo thank you for the contribution, you are amazing! Would you be able to rebase this feature branch against the latest to resolve the merge conflict? |
…-codemods into feat/add_attribute # Conflicts: # packages/cli/src/angular/migrations/standalone/0002-import-standalone-component.ts
|
@sean-perkins Thanks for checking, I've merged the main branch and resolved the conflicts. |
sean-perkins
approved these changes
Jan 30, 2024
|
Thanks for the merge. This is all the behavior I want to make better for now. I look forward to the day when EXPERIMENTAL is removed from this tool and more people will use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ios/md attribute: