Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs incorrect, scripts desctructive, missing options.... #618

Open
mchl18 opened this issue Aug 13, 2024 · 3 comments
Open

Docs incorrect, scripts desctructive, missing options.... #618

mchl18 opened this issue Aug 13, 2024 · 3 comments

Comments

@mchl18
Copy link

mchl18 commented Aug 13, 2024

Hi guys,

  1. docs ask us to npm install --save-dev @capacitor/assets but then a few lines later we are using npx so we just added it to our package.json it for no reason?
  2. Why does it always delete icons under src/assets/icons? I have never asked it to delete these and there is no option not to? Why be destructive? Just leave them there, they don't hurt nobody, or ask me if I want them deleted. These are in the damn assets folder, a folder that we might use within our app.
  3. Why is there no option to generate notification icons? We need a post-generate script that copies an icon to res/drawable because by itself, there is only a splash screen in there.
@marklagendijk
Copy link

@mchl18

  1. This allows for controlling the version of the tool. Which you should do.

The other 2 are valid points, but your tone is not.

@mchl18
Copy link
Author

mchl18 commented Sep 9, 2024

excuse my tone, there was general frustration in working with capacitor that lead up to my tone, I will try and get a PR up to fix the things I mentioned

@mchl18
Copy link
Author

mchl18 commented Sep 9, 2024

Will npx not always use whatever it can get from the registry? Or will it prefer the package.json version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants