Skip to content

Conversation

@cavalle
Copy link
Contributor

@cavalle cavalle commented Sep 15, 2025

  • Add new PR exemption codes released ~2 weeks ago

Pre-Review Checklist

  • I've read the CONTRIBUTING.md guide.
  • I have performed a self-review of my code.
  • N/A I have added thorough tests with at least 90% code coverage.
  • N/A I've modified or created example GOBL documents to show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes, either structured or in the comments.
  • I've run go generate . to ensure that the Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

@cavalle cavalle requested a review from samlown September 15, 2025 14:34
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (06b6c3b) to head (f4c2290).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         292      292           
  Lines       16429    16429           
=======================================
  Hits        14923    14923           
  Misses       1195     1195           
  Partials      311      311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be mapped alongside the other codes in the tax combo

Comment on lines +768 to +769
i18n.EN: "Artigo 58.º-A do CIVA",
i18n.PT: "Article 58.º-A of the CIVA",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation is backwards here.

@samlown
Copy link
Collaborator

samlown commented Sep 15, 2025

Do you have any clarity on the correct mapping of the VAT key to these codes? Its not very obvious from the outset.

Desc: i18n.String{
i18n.EN: here.Doc(`
To be used in operations not localized in Portugal due to the
exception rules in numbers 7 and following of article 6.º of the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be useful here to try and describe what the "exception rules in numbers 7 and following" actually are. All this description is really saying is the same thing as the title, but longer!

@samlown samlown marked this pull request as draft October 3, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants