-
Notifications
You must be signed in to change notification settings - Fork 21
Add new PT exemption codes #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 292 292
Lines 16429 16429
=======================================
Hits 14923 14923
Misses 1195 1195
Partials 311 311 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samlown
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these need to be mapped alongside the other codes in the tax combo
| i18n.EN: "Artigo 58.º-A do CIVA", | ||
| i18n.PT: "Article 58.º-A of the CIVA", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation is backwards here.
|
Do you have any clarity on the correct mapping of the VAT key to these codes? Its not very obvious from the outset. |
| Desc: i18n.String{ | ||
| i18n.EN: here.Doc(` | ||
| To be used in operations not localized in Portugal due to the | ||
| exception rules in numbers 7 and following of article 6.º of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be useful here to try and describe what the "exception rules in numbers 7 and following" actually are. All this description is really saying is the same thing as the title, but longer!
Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.