Skip to content

feat(ui): warn on unregistered invocation output #8056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

psychedelicious
Copy link
Collaborator

Summary

feat(ui): warn on unregistered invocation output

image

Related Issues / Discussions

@JPPhoto got hit with the lack of warning and led to confusion in https://discord.com/channels/1020123559063990373/1083864753543331981/1376954234356105279

QA Instructions

JP's node (without the decorator) should log a warning as the UI parses node templates

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the python PRs that change python files label May 27, 2025
Also change import order to ensure CLI args are handled correctly. Had to do this bc importing `InvocationRegistry` before parsing args resulted in the `--root` CLI arg being ignored.
@psychedelicious psychedelicious force-pushed the psyche/feat/unregistered-output-warning branch from 83948c7 to a3f67b6 Compare May 30, 2025 03:53
@github-actions github-actions bot added the invocations PRs that change invocations label May 30, 2025
@psychedelicious psychedelicious merged commit c848cbc into main May 30, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/unregistered-output-warning branch May 30, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants