Skip to content

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Fix invalid PyPI project classifiers which are preventing publishing to PyPI
  • Add a script to check them
  • Run the check in the build script
  • Run the check in CI

Related Issues / Discussions

See failing publish here https://github.com/invoke-ai/InvokeAI/actions/runs/15266095813/job/42932344184

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added CI-CD Continuous integration / Continuous delivery Root python-deps PRs that change python dependencies labels May 27, 2025
Copy link
Contributor

@jazzhaiku jazzhaiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psychedelicious

Approved because code is very readable and this is a blocker.
But wondering why not use a TOML parser lib? e.g.
https://docs.python.org/3/library/tomllib.html

@psychedelicious
Copy link
Collaborator Author

Didn't know about that module. I had ChatGPT write the script, apparently it also didn't know about the module.

It looks like that module wasn't added to python's stdlib until v3.11. We technically support v3.10, so I'll leave the script as-is.

@psychedelicious psychedelicious merged commit 675c990 into main May 27, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/build/pyproject-classifiers branch May 27, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-CD Continuous integration / Continuous delivery python-deps PRs that change python dependencies Root
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants