Skip to content

feat(ui): revised canvas scale snapping #8050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025

Conversation

psychedelicious
Copy link
Collaborator

Summary

Revised scale snapping on canvas.

Tracks the "intended" scale separately from "effective" scale to allow for snapping that does not inadvertently lock the scale to snap points, as described in #8048.

Also removed a couple constraints that were causing some jank:

  • Canvas Scale is no longer rounded, allowing the scaling on touchpads to be smoother and get "stuck" less
  • Canvas Position is no longer rounded, preventing the drift of canvas position while scaling in and out

Related Issues / Discussions

n/a

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label May 27, 2025
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/scroll-snap branch from 686c874 to 8814f35 Compare May 27, 2025 03:08
@psychedelicious psychedelicious enabled auto-merge (rebase) May 27, 2025 03:09
@psychedelicious psychedelicious merged commit a2d8261 into main May 27, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/scroll-snap branch May 27, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants