-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save Device Settings > Colors settings in the backend #333
Comments
All settings on Settings > Device Settings are specific to the device |
Why not save colours as a user preference to the db and have those settings be global? Either way, an issue is still present as demonstrated in the video where the sidebar remains black when when switching back to the light theme. This black sidebar occurs as soon as you sign in from another or PC browser, rather than than showing the light theme correctly by default. In other words, it acts like the dark sidebar prefence is synced across browsers or devices, but nothing else. |
I agree it would be useful to save the color settings to the db. The dark sidebar is the default with the light mode, you can remove it using the "Load color theme" option. |
Ah okay. When v5 is first installed, everything was white so I thought that the light theme was light all around, including the sidebar. Not a major issue though but having the appearance the same across devices would be great to see eventually :) |
What version of Invoice Ninja are you running? ie v4.5.25 / v5.0.30
v5.3.16-C59
What environment are you running?
Shared Hosting
Describe the bug
If I set the theme to dark on one PC in a given browser, then log into Invoice Ninja v5 on another PC, the dark theme is not remembered for the same user. However certain elements seem to be? Such as the sidebar remaining dark, and the rest remaining light. Even when toggling the dark theme to light, the sidebar remains persistent as dark. Only way to correct it is to manually go ahead and reset all the colours. It's glitchy, see video.
Steps To Reproduce
Set the theme as dark on one PC/browser, then sign in on another PC/browser as the same user.
VIDEO: https://youtu.be/qYI_OuXCXIQ
Expected behavior
Theme settings should remain persistent regardless of browser and login location.
The text was updated successfully, but these errors were encountered: