Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Device Settings > Colors settings in the backend #333

Open
mrkylegp opened this issue Sep 20, 2021 · 5 comments
Open

Save Device Settings > Colors settings in the backend #333

mrkylegp opened this issue Sep 20, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@mrkylegp
Copy link

mrkylegp commented Sep 20, 2021

What version of Invoice Ninja are you running? ie v4.5.25 / v5.0.30
v5.3.16-C59

What environment are you running?
Shared Hosting

Describe the bug
If I set the theme to dark on one PC in a given browser, then log into Invoice Ninja v5 on another PC, the dark theme is not remembered for the same user. However certain elements seem to be? Such as the sidebar remaining dark, and the rest remaining light. Even when toggling the dark theme to light, the sidebar remains persistent as dark. Only way to correct it is to manually go ahead and reset all the colours. It's glitchy, see video.

Steps To Reproduce
Set the theme as dark on one PC/browser, then sign in on another PC/browser as the same user.

VIDEO: https://youtu.be/qYI_OuXCXIQ

themeerror

Expected behavior
Theme settings should remain persistent regardless of browser and login location.

@hillelcoren hillelcoren transferred this issue from invoiceninja/invoiceninja Sep 20, 2021
@hillelcoren
Copy link
Member

All settings on Settings > Device Settings are specific to the device

@mrkylegp
Copy link
Author

mrkylegp commented Sep 20, 2021

All settings on Settings > Device Settings are specific to the device

Why not save colours as a user preference to the db and have those settings be global?

Either way, an issue is still present as demonstrated in the video where the sidebar remains black when when switching back to the light theme. This black sidebar occurs as soon as you sign in from another or PC browser, rather than than showing the light theme correctly by default. In other words, it acts like the dark sidebar prefence is synced across browsers or devices, but nothing else.

@hillelcoren
Copy link
Member

I agree it would be useful to save the color settings to the db.

The dark sidebar is the default with the light mode, you can remove it using the "Load color theme" option.

@hillelcoren hillelcoren added the enhancement New feature or request label Sep 21, 2021
@hillelcoren hillelcoren changed the title Light/Dark theme is not remembered across browsers and/or is not consistent Save Device Settings > Colors settings in the backend Sep 21, 2021
@mrkylegp
Copy link
Author

I agree it would be useful to save the color settings to the db.

The dark sidebar is the default with the light mode, you can remove it using the "Load color theme" option.

Ah okay. When v5 is first installed, everything was white so I thought that the light theme was light all around, including the sidebar. Not a major issue though but having the appearance the same across devices would be great to see eventually :)

@mrkylegp
Copy link
Author

mrkylegp commented Dec 3, 2022

Adding to this, I prefer to have the preview location as "Side". Would be great not to have to set this per device and instead sync it with the account.

Screenshot 2022-12-03 155451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants