-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(firestore): implement withCoverter #8744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(firestore): implement withCoverter #8744
Conversation
|
@JiriHoffmann is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
That is not something I'm used to people apologizing for, this certainly looks worth it. Thanks! Going in the review queue - additionally - if my patch-package generation workflow is working correctly you should be able to start depending on the work relatively easily already via usage of the patch, which should apply cleanly to the current released version of |
|
Looks like there are a couple things going on here in the CI failures - 1- there's an error in types-test with an unused 'doc' element
2- there's some use of non-modular code in the new modular e2e tests
3- Then, seemingly unrelated to this PR, there's a problem with the ios build where some sort of entropy ("things just fail over time for unrelated reasons") has taken over and resulted in
1 and 2 are for this PR, I'll tackle 3 separately and either cherry-pick or rebase it into this PR, coordinating with you as/when I do so |
Description
Hello! I'm sorry for introducing such a large PR, but I hope it's gonna be worth it.
This PR adds the withCoverter functionality to both the namespace and modular APIs and updates types accordingly.
Both type and e2e tests are a 1:1 copy of the Firebase JS SDK to ensure feature parity.
Related issues
Closes #8611 and these 2 PRs #8698 #8672
Release Summary
Implements
withConverterfrom Firebase JS SDKChecklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__🔥