Skip to content

feat(functions): turbo modules implementation #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

russellwheatley
Copy link
Member

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2025 9:02am

@russellwheatley russellwheatley changed the title Functions turbo feat(functions): turbo modules implementation Jul 8, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 do we want to commit all the generated files, or just have them in .gitignore and call lerna codegen as part of lerna prepare + list them in package.json::files so they're part of the local + CI builds and get packed up for npmjs.com ?

@russellwheatley
Copy link
Member Author

russellwheatley commented Jul 8, 2025

@mikehardy - Yep, I think it would be preferable to ignore generated files actually. I think there's a number of files that don't apply to RNFB packages anyway - related to UI generated code. I'm still in the phase of getting this to work, I have iOS building successfully (although not tested yet if everything breaks once API used), android is not building successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants