-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(functions): turbo modules implementation #8603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 do we want to commit all the generated files, or just have them in .gitignore and call lerna codegen
as part of lerna prepare + list them in package.json::files so they're part of the local + CI builds and get packed up for npmjs.com ?
@mikehardy - Yep, I think it would be preferable to ignore generated files actually. I think there's a number of files that don't apply to RNFB packages anyway - related to UI generated code. I'm still in the phase of getting this to work, I have iOS building successfully (although not tested yet if everything breaks once API used), android is not building successfully. |
Description
Related issues
Release Summary
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter