[Messaging] Add null check to acquire WakeLock on Android #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe related to #1174 |
timwangdev
changed the title
|
Update a PR on facebook/react-native#24671 to handle the case if no tasks registered in js. |
Salakar
added
plugin: messaging
Salakar
approved these changes
May 3, 2019
|
@timwangdev thanks for this and also for sending up the React Native PR 👏 For the RN PR, I've made a request to get it cherry-picked into the RN 0.60.x release if you'd like to track it: react-native-community/releases#116 (comment) I'll go ahead and merge this PR - I'll do a v5 patch release end of next week. |
robertbarclay
added a commit
to robertbarclay/react-native-firebase
that referenced
this pull request
May 28, 2019
* v5.x.x: 5.4.0 [tests] disable admob (has a new runtime check that causes a crash as we don't have a valid admob identifier) [android] update firebase sdk versions - forced to upgrade due to invertase#2122 [android][internals] rework internals utils to better support JSONObject/Array values [GENERAL][BUGFIX][build] - patch v5 build toolchains for XCode10.2 & RN0.59 compatibility (invertase#2166) [tests] update podfile lock [tests] sync v5.x.x local changes [tests] sync v5.x.x local changes [docs] update link [STORAGE][BUGFIX][ANDROID] - Preserve `file://` prefix [JS][BUGFIX] [package.json] - Fix build on Windows (BABEL_ENV error) [Messaging] Add null check to acquire WakeLock on Android (invertase#2092) [TYPES][BUGFIX][AUTHENTICATION] - Change type PhoneAuthSnapshot.Error to NativeError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Message module and Notification module will accidentally acquire a
PARTIAL_WAKE_LOCKby callingHeadlessJsTaskService.acquireWakeLockNow(), and this lock will always hold if no js tasks to consume it. This will drain off user phones' battery.This happens when you init the Message module without the optional step of adding
RNFirebaseBackgroundMessagingServiceto theAndroidManifest.xml.The
context.startService()will not throw on unregistered service, it justreturn null. Adding a null check will handle the cases.On the Notification module, the service is undocumented, should have fewer people using it.
Checklist
AndroidiOSe2etests added or updated in /tests/e2e/*Test Plan
Tested on a private production app.
Release Plan
[ANDROID][BUGFIX] [Messaging] - Add null checks to avoid accidentally acquiring wakelocks on Android.
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter