-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to docstrings HourEnding and HourBegining have default inclusivity #77
Labels
good first issue
Good for newcomers
Comments
Makes sense to me. And isn't it already the case? julia> using Intervals, Dates
julia> HourEnding(DateTime(2017, 02, 28, 06))
AnchoredInterval{-1 hour,DateTime}(2017-02-28T06:00:00, Inclusivity(false, true))
julia> HourBeginning(DateTime(2017, 02, 28, 06))
AnchoredInterval{1 hour,DateTime}(2017-02-28T06:00:00, Inclusivity(true, false))
(tmp.BCUQL3co) pkg> status Intervals
Status `/private/var/folders/hx/1h0bbkfd18d4n1qrnwmrl4j00000gn/T/tmp.BCUQL3co/Project.toml`
[d8418881] Intervals v0.5.1 |
we should add it to the docstrings.... |
yes, could be said in words it is there in the examples Intervals.jl/src/anchoredinterval.jl Lines 33 to 58 in 6010f10
|
nickrobinson251
changed the title
Should HourEnding and HourBegining default inclusivity?
Add to docstrings HourEnding and HourBegining have default inclusivity
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To me it seems like a natural assumption that
HourEnding
would have inclusivity offalse, true
,and
HourBeginning
would have inclusivity oftrue, false
but I am not sure if I am typical or not.
The text was updated successfully, but these errors were encountered: