Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkpoint_fullname(x::IndexEntry) #28

Closed
oxinabox opened this issue Jul 14, 2021 · 0 comments · Fixed by #38
Closed

add checkpoint_fullname(x::IndexEntry) #28

oxinabox opened this issue Jul 14, 2021 · 0 comments · Fixed by #38
Assignees
Labels
good first issue Good for newcomers

Comments

@oxinabox
Copy link
Member

If we know a checkpoint's name expressed in the MODULE.SUBMODULE.NAME form
then right now you need to do
split(fullname)[1:end-1] == prefixes(x) && last(split(fullname)) == checkpoint_name(x)
to see if it matches some x from the index.

That is pretty gross.

We should add checkpoint_fullname(x::IndexEntry) = join(".", [prefixes(x); checkpoint_name(x)])
or something like that.
So that it can be checked easily.

@oxinabox oxinabox added the good first issue Good for newcomers label Jul 14, 2021
@oxinabox oxinabox self-assigned this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant