Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests failing due to printing changes in 1.7 #68

Closed
fchorney opened this issue Jan 20, 2022 · 2 comments
Closed

Doctests failing due to printing changes in 1.7 #68

fchorney opened this issue Jan 20, 2022 · 2 comments
Assignees

Comments

@fchorney
Copy link
Member

https://github.com/invenia/AxisSets.jl/runs/4876807034?check_suite_focus=true

@iamed2 iamed2 changed the title CI: Doctests failing Doctests failing due to one-column Matrix printing changes in 1.7 Jan 20, 2022
@iamed2 iamed2 changed the title Doctests failing due to one-column Matrix printing changes in 1.7 Doctests failing due to printing changes in 1.7 Jan 20, 2022
@iamed2
Copy link
Member

iamed2 commented Jan 20, 2022

A cursory look shows some of these related to how a Matrix with one column is displayed.

In 1.6:

julia> print(reshape([7.0; 8.0; 9.0], 3, 1))
[7.0; 8.0; 9.0]
julia> print([7.0; 8.0; 9.0])
[7.0, 8.0, 9.0]

Note that this is not round-trippable; both evaluate to a Vector

In 1.7:

julia> print(reshape([7.0; 8.0; 9.0], 3, 1))
[7.0; 8.0; 9.0;;]
julia> print([7.0; 8.0; 9.0])
[7.0, 8.0, 9.0]

this is round-trippable.

Some relate to Set ordering when printing, which can change when the RNG changes.

I'm not sure, but I think the last one is related to the printing of errors, where now failures can print a diff. It's hard to tell though as that's kind of meta.

@arnaudh arnaudh self-assigned this Jan 24, 2022
@arnaudh
Copy link
Contributor

arnaudh commented Jan 26, 2022

Fixed with #70

@arnaudh arnaudh closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants