Added line spacing between outputs, moved scanner from instance variable to local variable for methods.

Author: rawrspace

BankApp/src/Checking.java

@@ -3,7 +3,6 @@ public class Checking extends Account{
     private static String accountType = "Checking";
 
     Checking(double initialDeposit){
-        super();
         this.setBalance(initialDeposit);
         this.checkInterest(0);
     }

BankApp/src/Customer.java

@@ -31,10 +31,7 @@ public String toString(){
     }
 
     public String basicInfo(){
-        return "First Name: " + firstName +
-                " Last Name: " + lastName + 
-                " SSN: " + ssn + 
-                " Account Number: " + account.getAccountNumber();
+        return " Account Number: " + account.getAccountNumber() + " - Name: " + firstName + " " + lastName;
     }
 
     Account getAccount(){

BankApp/src/Menu.java

@@ -9,7 +9,6 @@
 public class Menu {
 
     //Instance Variables
-    Scanner keyboard = new Scanner(System.in);
     Bank bank = new Bank();
     boolean exit;
 
@@ -22,7 +21,7 @@ public void runMenu() {
         printHeader();
         while (!exit) {
             printMenu();
-            int choice = getInput();
+            int choice = getMenuChoice();
             performAction(choice);
         }
     }
@@ -35,15 +34,16 @@ private void printHeader() {
     }
 
     private void printMenu() {
-        System.out.println("Please make a selection: ");
+        displayHeader("Please make a selection");
         System.out.println("1) Create a new Account");
         System.out.println("2) Make a deposit");
         System.out.println("3) Make a withdrawal");
         System.out.println("4) List account balance");
         System.out.println("0) Exit");
     }
 
-    private int getInput() {
+    private int getMenuChoice() {
+        Scanner keyboard = new Scanner(System.in);
         int choice = -1;
         do {
             System.out.print("Enter your choice: ");
@@ -89,7 +89,7 @@ private void performAction(int choice) {
 
     private String askQuestion(String question, List<String> answers) {
         String response = "";
-        Scanner input = new Scanner(System.in);
+        Scanner keyboard = new Scanner(System.in);
         boolean choices = ((answers == null) || answers.size() == 0) ? false : true;
         boolean firstRun = true;
         do {
@@ -105,7 +105,7 @@ private String askQuestion(String question, List<String> answers) {
                 System.out.print(answers.get(answers.size() - 1));
                 System.out.print("): ");
             }
-            response = input.nextLine();
+            response = keyboard.nextLine();
             firstRun = false;
             if (!choices) {
                 break;
@@ -115,6 +115,7 @@ private String askQuestion(String question, List<String> answers) {
     }
 
     private double getDeposit(String accountType) {
+        Scanner keyboard = new Scanner(System.in);
         double initialDeposit = 0;
         Boolean valid = false;
         while (!valid) {
@@ -142,6 +143,7 @@ private double getDeposit(String accountType) {
     }
 
     private void createAnAccount() throws InvalidAccountTypeException {
+        displayHeader("Create an Account");
         //Get account information
         String accountType = askQuestion("Please enter an account type: ", Arrays.asList("checking", "savings"));
         String firstName = askQuestion("Please enter your first name: ", null);
@@ -161,7 +163,8 @@ private void createAnAccount() throws InvalidAccountTypeException {
         bank.addCustomer(customer);
     }
 
-    private double getAmount(String question) {
+    private double getDollarAmount(String question) {
+        Scanner keyboard = new Scanner(System.in);
         System.out.print(question);
         double amount = 0;
         try {
@@ -173,37 +176,56 @@ private double getAmount(String question) {
     }
 
     private void makeADeposit() {
+        displayHeader("Make a Deposit");
         int account = selectAccount();
         if (account >= 0) {
-            double amount = getAmount("How much would you like to deposit?: ");
+            double amount = getDollarAmount("How much would you like to deposit?: ");
             bank.getCustomer(account).getAccount().deposit(amount);
         }
     }
 
     private void makeAWithdrawal() {
+        displayHeader("Make a Withdrawal");
         int account = selectAccount();
         if (account >= 0) {
-            double amount = getAmount("How much would you like to withdraw?: ");
+            double amount = getDollarAmount("How much would you like to withdraw?: ");
             bank.getCustomer(account).getAccount().withdraw(amount);
         }
     }
 
     private void listBalances() {
+        displayHeader("List Account Details");
         int account = selectAccount();
         if (account >= 0) {
+            displayHeader("Account Details");
             System.out.println(bank.getCustomer(account).getAccount());
         }
     }
+    
+    private void displayHeader(String message){
+        System.out.println();
+        int width = message.length() + 6;
+        StringBuilder sb = new StringBuilder();
+        sb.append("+");
+        for(int i = 0; i < width; ++i){
+            sb.append("-");
+        }
+        sb.append("+");
+        System.out.println(sb.toString());
+        System.out.println("|   " + message + "   |");
+        System.out.println(sb.toString());
+    }
 
     private int selectAccount() {
+        Scanner keyboard = new Scanner(System.in);
         ArrayList<Customer> customers = bank.getCustomers();
         if (customers.size() <= 0) {
             System.out.println("No customers at your bank.");
             return -1;
         }
         System.out.println("Select an account:");
         for (int i = 0; i < customers.size(); i++) {
-            System.out.println((i + 1) + ") " + customers.get(i).basicInfo());
+            System.out.println("\t" + (i + 1) + ") " + customers.get(i).basicInfo());
         }
         int account;
         System.out.print("Please enter your selection: ");

BankApp/src/Savings.java

@@ -3,7 +3,6 @@ public class Savings extends Account{
     private static String accountType = "Savings";
 
     Savings(double initialDeposit){
-        super();
         this.setBalance(initialDeposit);
         this.checkInterest(0);
     }