Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.9 support #209

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Python 3.9 support #209

merged 7 commits into from
Aug 20, 2024

Conversation

ndxmrb
Copy link
Contributor

@ndxmrb ndxmrb commented Aug 19, 2024

Fixes #208.

Utilizes from __future__ import annotations and datetime.timezone.utc to keep Python 3.9 supported.
The datetime.UTC alias was added in Python 3.11, so this might have affected 3.10 as well.

Tests pass, albeit test_http_error_old_config_found both fail at first, but always pass on the second try.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (705b1e9) to head (d9b12d4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files           6        6           
  Lines         266      267    +1     
=======================================
+ Hits          266      267    +1     
Files Coverage Δ
fastapi_azure_auth/exceptions.py 100.0% <100.0%> (ø)

@ndxmrb ndxmrb marked this pull request as draft August 19, 2024 15:40
@ndxmrb ndxmrb marked this pull request as ready for review August 19, 2024 15:48
@JonasKs
Copy link
Member

JonasKs commented Aug 19, 2024

Thanks so much! Could you add python3.9 to the test suite? I think I mistakenly removed those at some point, and never catched it in my self-review of the 5.0-release.

fastapi_azure_auth/exceptions.py Outdated Show resolved Hide resolved
fastapi_azure_auth/exceptions.py Outdated Show resolved Hide resolved
@ndxmrb
Copy link
Contributor Author

ndxmrb commented Aug 20, 2024

Adding 3.9, sure. 3.10 is also missing, shall I add it too, or do you want to do it in a 3.10 support branch?

@JonasKs
Copy link
Member

JonasKs commented Aug 20, 2024

3.10 is good too😊 Thanks!

@JonasKs
Copy link
Member

JonasKs commented Aug 20, 2024

Thank you so much!! 😊

@JonasKs JonasKs merged commit a0e3be0 into intility:main Aug 20, 2024
10 checks passed
@JonasKs
Copy link
Member

JonasKs commented Aug 20, 2024

Release triggered here: https://github.com/Intility/fastapi-azure-auth/releases/tag/5.0.1.
Should be on PyPi in a few minutes.

@ndxmrb
Copy link
Contributor Author

ndxmrb commented Aug 20, 2024

You're welcome! I'm glad to do my part 😊
And thanks for the fast release to PyPI 👍

@ndxmrb ndxmrb deleted the 3.9-support branch August 20, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG/Question] Python 3.9 still supported?
2 participants