-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.9 support #209
Python 3.9 support #209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 6 6
Lines 266 267 +1
=======================================
+ Hits 266 267 +1
|
Thanks so much! Could you add python3.9 to the test suite? I think I mistakenly removed those at some point, and never catched it in my self-review of the 5.0-release. |
This reverts commit 84c7214.
Adding 3.9, sure. 3.10 is also missing, shall I add it too, or do you want to do it in a 3.10 support branch? |
3.10 is good too😊 Thanks! |
Thank you so much!! 😊 |
Release triggered here: https://github.com/Intility/fastapi-azure-auth/releases/tag/5.0.1. |
You're welcome! I'm glad to do my part 😊 |
Fixes #208.
Utilizes
from __future__ import annotations
anddatetime.timezone.utc
to keep Python 3.9 supported.The datetime.UTC alias was added in Python 3.11, so this might have affected 3.10 as well.
Tests pass, albeit
test_http_error_old_config_found
both fail at first, but always pass on the second try.