Improve remote management on settings page #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dating, or removing the remote. adds the constraint that we only operate on a single remote named origin. previously multiple remotes had undefined behavior.
…ors are better reported
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 41.30% 41.30%
=======================================
Files 24 24
Lines 3213 3220 +7
=======================================
+ Hits 1327 1330 +3
- Misses 1886 1890 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-etamarch
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #746
Adding, removing, and updating remote now all work on the settings page.
Since settings page only allows changing a single remote, this is now constrained to be the "origin" remote. Previously behavior was undefined if there were multiple remotes.
If remote is defined, we now test connection and display a warning message if it fails.