Skip to content

Fix errors with decomposed production with invalid cache entries #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

isc-pbarton
Copy link
Collaborator

Closes #701

  • Fix an error when there is a leftover entry in the Git items cache for the undecomposed production class
  • Removes Add to / Remove From Source Control options from menu for decomposed production since they do nothing

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.29%. Comparing base (b29baf0) to head (3f6851e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cls/SourceControl/Git/Extension.cls 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   41.33%   41.29%   -0.05%     
==========================================
  Files          23       23              
  Lines        3174     3175       +1     
==========================================
- Hits         1312     1311       -1     
- Misses       1862     1864       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isc-tleavitt isc-tleavitt merged commit cd942e7 into main Jan 31, 2025
2 checks passed
@isc-tleavitt isc-tleavitt deleted the fix-decomp-bad-cache branch January 31, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors saving decomposed production item when invalid entries in item cache
3 participants