Skip to content

Fix $ZF MAX STRINGLENGTH issue #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 7, 2025
Merged

Fix $ZF MAX STRINGLENGTH issue #649

merged 12 commits into from
Jan 7, 2025

Conversation

isc-etamarch
Copy link
Collaborator

Fixes #617

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 97 lines in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (fadbaab) to head (dbbd81c).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 0.00% 49 Missing ⚠️
cls/SourceControl/Git/WebUIDriver.cls 0.00% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   41.32%   40.45%   -0.87%     
==========================================
  Files          23       23              
  Lines        3071     3137      +66     
==========================================
  Hits         1269     1269              
- Misses       1802     1868      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points of feedback here.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments here, sorry for the endless loop of this.

@isc-tleavitt
Copy link
Collaborator

@isc-etamarch sorry this sat so long - we have a nontrivial merge conflict in WebUIDriver, could you resolve conflicts and re-test locally?

@isc-tleavitt isc-tleavitt merged commit 8f69b52 into main Jan 7, 2025
2 checks passed
@isc-tleavitt isc-tleavitt deleted the issue-617 branch January 7, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<MAX $ZF STRING> trying to commit a very large number of files simultaneously
3 participants