-
Notifications
You must be signed in to change notification settings - Fork 9
Fix $ZF MAX STRINGLENGTH issue #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 41.32% 40.45% -0.87%
==========================================
Files 23 23
Lines 3071 3137 +66
==========================================
Hits 1269 1269
- Misses 1802 1868 +66 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few points of feedback here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments here, sorry for the endless loop of this.
@isc-etamarch sorry this sat so long - we have a nontrivial merge conflict in WebUIDriver, could you resolve conflicts and re-test locally? |
Fixes #617