Added Environment #520
Merged
Added Environment #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ask for environment in configuration; Add changing environment in settings; Show environment in UI
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 25.60% 25.59% -0.01%
==========================================
Files 18 18
Lines 2582 2594 +12
==========================================
+ Hits 661 664 +3
- Misses 1921 1930 +9 ☔ View full report in Codecov by Sentry. |
isc-pbarton
previously requested changes
Oct 8, 2024
Set environment lobal through method, default environment name to empty
isc-tleavitt
requested changes
Oct 9, 2024
Use $SYSTEM.Version.SystemMode to deal with environment name Add 'Failover' as an option
isc-tleavitt
requested changes
Oct 9, 2024
Wrap the environment setting in a try catch to avoid error if user does not have enough priveledges
isc-tleavitt
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask for environment in configuration; Add changing environment in settings; Show environment in UI
fixes (#124 )