Skip to content

Improved behavior for commits when attribution settings are not configured #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

isc-akadoo
Copy link
Contributor

Fixes #450

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 37.14286% with 22 lines in your changes missing coverage. Please review.

Project coverage is 32.05%. Comparing base (6ad5fe0) to head (21e5044).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 44.00% 14 Missing ⚠️
cls/SourceControl/Git/Extension.cls 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   25.06%   32.05%   +6.98%     
==========================================
  Files          18       18              
  Lines        2541     3107     +566     
==========================================
+ Hits          637      996     +359     
- Misses       1904     2111     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback; also, as I'd said via Teams: It would also be helpful to produce some output on initial connection (via VSCode/Studio - this is the Type = 1, Name = 5 block in SourceControl.Git.Extension:UserAction) to provide an earlier warning.

@isc-tleavitt isc-tleavitt self-requested a review October 2, 2024 19:30
@isc-tleavitt isc-tleavitt merged commit b6eb0ba into main Oct 3, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the fix-450 branch October 3, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behave better if attribution settings are not configured
3 participants