Skip to content

Don't automatically stage files added to source control #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

isc-vgao
Copy link
Contributor

@isc-vgao isc-vgao commented Jan 8, 2024

This fixes #303

Testing Steps:

  1. In git-source-control repo, checkout noStagingForAdd branch
git checkout noStagingForAdd
  1. Load git-source-control into the current namespace
zpm "load <path to local git-source-control repo>"
  1. Create a new class.
  2. Add the class file to source control.
git add <path to file>
  1. In Management Portal Favorites section, open git-source-control UI and click Workspace on the side navigation menu.
  2. Verify that the new class you added in step 3 doesn't show up in Working Copy or Staging Area sections.
  3. Modify the class you added in step 3 and save.
  4. Verify that the class now shows up in the Working Copy section.
  5. Click "Stage" button in Working Copy section.
  6. Verify that the class now shows up in the Staging Area section and is no longer in Working Copy section.
  7. Refresh the page, click Workspace on the side navigation menu and verify that the class still shows up in the Staging Area section.
  8. Click "Unstage" button in Staging Area section.
  9. Verify that the class now shows up in the Working Copy section and is no longer in Staging Area section.
  10. Delete the class you added in step 3, refresh the page, click Workspace on the side navigation menu and verify that the class is no longer in Working Copy or Staging Area sections.

@isc-vgao isc-vgao self-assigned this Jan 8, 2024
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa - wasn't expecting this to be fully a UI issue. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add of file shouldn't automatically stage
2 participants