Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use login type configuration from ICM instead of hard coded type 'email' #944

Open
shauke opened this issue Dec 3, 2021 · 2 comments
Open
Labels
enhancement Enhancement to an existing feature

Comments

@shauke
Copy link
Collaborator

shauke commented Dec 3, 2021

Is your feature request related to a problem? If yes, please describe it.

ICM provides two options for user registration with the email address or with a chosen username. Currently the PWA is prepared to handle both ways but by default the registration and login are hard coded to use email (see src\app\core\configurations\injection-keys.ts).

/**
 * If 'username' login name is used for registration, if 'email' the email is used as login name (default: 'email')
 */
export const USER_REGISTRATION_LOGIN_TYPE = new InjectionToken<string>('userRegistrationLoginType', {
  factory: () => 'email',
});

Describe the desired solution.

Currently the ICM configurations REST call does not provide the information which login type is configured in the ICM backoffice. As soon as this is fixed the PWA needs to be adapted to handle both ways dynamically in accordance with the ICM configuration.

The login with username is not fully supported by the pwa, yet. Only the login page is showing the username. The registration page, the profile pages and maybe some other components have to be adapted, too.

Provide additional context.

AB#71466 REST: Preference LoginType not provided by GET /configurations call

AB#71849

@shauke shauke added the enhancement Enhancement to an existing feature label Dec 3, 2021
@shauke
Copy link
Collaborator Author

shauke commented Dec 9, 2021

This is now available (at least in 7.10.36.0) and can be implemented.
image

@MaxKless MaxKless added the wait Waiting for something (e.g. new ICM release) label Feb 16, 2022
@5t3v3n-H 5t3v3n-H removed the wait Waiting for something (e.g. new ICM release) label Sep 22, 2022
@Thomas-Bergmann
Copy link
Contributor

The REST-client (PWA) doesn't need to care about the preference "UserRegistrationLoginType" at login. Only for registration and update profile. The type can improve the UI. In case of "email" both fields "login" and "email" can be displayed as one.
The ICM uses the "login", always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants