Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personalization group (s)pgid is missing in request call for top level categories #351

Closed
kapilmishra-evident opened this issue Jul 29, 2020 · 3 comments
Labels
enhancement Enhancement to an existing feature
Milestone

Comments

@kapilmishra-evident
Copy link

kapilmishra-evident commented Jul 29, 2020

In current version, an API call is there from method getTopLevelCategories in categories.service.ts to fetch top level categories to display on home page.

Actual Behavior
Mentioned call doesn't include personalized group parameters in URL (s)pgid. If I change line 47 of categories.service.ts file to include sendSPGID parameter as

return this.apiService.get('categories', { **sendSPGID: true**, params }).pipe(
spgid gets added to the request, but with undefined value.

image

Expected Behavior
Personalization parameter should be included in top level categories call with correct value.

Steps to Reproduce the Bug

  1. Go to PWA homepage
  2. Login with valid account.
  3. Navigate to home page again and check top level categories call in developer console.
  4. Notice URL is missing with personalization group (s)pgid parameter.

To me it seems pgid get set in store after the call to top level categories made. So for mentioned call pgid is always undefined. But for subsequent calls to sub-categories and products valid pgid is present in store and Urls.

AB#74392

@kapilmishra-evident kapilmishra-evident added the bug Something isn't working label Jul 29, 2020
@rkarl-ish
Copy link
Contributor

Hi Kapil,
thank you for raising this bug. Currently we only support personalization of CMS content in PWA out of the box. Personalization of products, prices and categories is one of the next topics we want to address but currently it is not in progress. We are going to handle this issue once we work on personalization in a larger context.

@shauke shauke added enhancement Enhancement to an existing feature and removed bug Something isn't working labels Oct 14, 2020
@shauke shauke reopened this Oct 14, 2020
@shauke
Copy link
Collaborator

shauke commented Oct 14, 2020

Converted to feature request.

@MaxKless
Copy link
Collaborator

Closing this in favor of the new and more general #315, which is being worked on right now! 🚀

@shauke shauke added this to the 2.1 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants