fix: merge product information for lower product completeness levels (#…

…1279) * update product information, add attributes even if the completeness level of the incoming product is lower than the existing one
intershop · Sep 23, 2022 · eec9cda · eec9cda
1 parent 856b3f7
commit eec9cda
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/app/core/models/product/product.helper.spec.ts b/src/app/core/models/product/product.helper.spec.ts
@@ -336,6 +336,7 @@ describe('Product Helper', () => {
       } as Product;
       stubProduct = {
         sku: '110',
+        longDescription: 'additional info',
         completenessLevel: 0,
         name: 'Stub Product',
         available: false,
@@ -366,6 +367,7 @@ describe('Product Helper', () => {
         Object {
           "available": false,
           "completenessLevel": 0,
+          "longDescription": "additional info",
           "name": "Stub Product",
           "sku": "110",
         }
@@ -402,6 +404,7 @@ describe('Product Helper', () => {
           "available": false,
           "availableStock": undefined,
           "completenessLevel": 3,
+          "longDescription": "additional info",
           "manufacturer": "Detail Manufacturer",
           "name": "Detail Product",
           "shortDescription": "The best product",

diff --git a/src/app/core/models/product/product.helper.ts b/src/app/core/models/product/product.helper.ts
@@ -180,8 +180,10 @@ export class ProductHelper {
     if (!product.completenessLevel || newProduct.completenessLevel >= product.completenessLevel) {
       return newProduct as AllProductTypes;
     }
+    // if the newProduct information has a lower completeness level merge attributes and
     // always update dynamic product information with the new product information (e.g. availability)
     product = {
+      ...newProduct,
       ...product,
       // list of product properties that should be updated
       available: newProduct.available ?? product.available,

diff --git a/src/app/core/store/shopping/products/products.selectors.spec.ts b/src/app/core/store/shopping/products/products.selectors.spec.ts
@@ -102,7 +102,7 @@ describe('Products Selectors', () => {
         store$.dispatch(loadProductSuccess({ product: newProd }));
 
         expect(getProductEntities(store$.state)).toEqual({
-          [prod.sku]: { ...prod, available: false, availableStock: undefined },
+          [prod.sku]: { ...prod, available: false, manufacturer: 'Microsoft', availableStock: undefined },
         });
       });
     });