fix: cms carousel component should handle not completely filled slides (

#663)
intershop · Apr 19, 2021 · baff0c4 · baff0c4
1 parent 961a087
commit baff0c4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/app/core/utils/functions.spec.ts b/src/app/core/utils/functions.spec.ts
@@ -27,12 +27,15 @@ describe('Functions', () => {
       expect(arraySlices(arr, 6)).toEqual([[1, 2, 3, 4, 5, 6]]);
     });
 
-    it('should return truncated result for length 8', () => {
-      expect(arraySlices(arr, 8)).toBeEmpty();
+    it('should return correctly sliced arrays of length 8', () => {
+      expect(arraySlices(arr, 8)).toEqual([[1, 2, 3, 4, 5, 6]]);
     });
 
-    it('should return truncated result for length 4', () => {
-      expect(arraySlices(arr, 4)).toEqual([[1, 2, 3, 4]]);
+    it('should return correctly sliced arrays of length 4', () => {
+      expect(arraySlices(arr, 4)).toEqual([
+        [1, 2, 3, 4],
+        [5, 6],
+      ]);
     });
 
     it('should return undefined when input is undefined or empty', () => {

diff --git a/src/app/core/utils/functions.ts b/src/app/core/utils/functions.ts
@@ -8,7 +8,7 @@ import { Observable, isObservable, of } from 'rxjs';
 export const arraySlices = <T>(input: T[], sliceLength: number): T[][] =>
   input && input.length && sliceLength > 0
     ? // determine slice indexes
-      range(0, Math.floor(input.length / sliceLength))
+      range(0, Math.ceil(input.length / sliceLength))
         // cut array into slices
         .map(n => input.slice(n * sliceLength, (n + 1) * sliceLength))
     : undefined;