Skip to content

Commit

Permalink
chore: remove unused http-loader dep (#1154)
Browse files Browse the repository at this point in the history
* docs: add reference to implementation for loading translations from an external source (see #927)

BREAKING CHANGES: The @ngx-translate/http-loader has been removed from the dependencies.
  • Loading branch information
MaxKless authored Jul 12, 2022
1 parent 3bd0626 commit 636a6e2
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 23 deletions.
5 changes: 5 additions & 0 deletions docs/concepts/localization.md
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,11 @@ This has to fit to your PWA environment.
This allows to enable easy filtering.
The prefixes will be removed when the translations are loaded into the PWA.

## External Localization Sources

The Intershop PWA presents no native way to use a different external source for loading translations in JSON format.
The pull request [feat: allow translations to be loaded from an external source](https://github.com/intershop/intershop-pwa/pull/927) presents a way how such an external service could be integrated and configured in the Intershop PWA.

## Localization File Clean Up Process

Localization files require constant maintenance to keep them up to date.
Expand Down
3 changes: 3 additions & 0 deletions docs/guides/migrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ In order to match our changes, replace all occurrences of `angular2-uuid` in you

The [pagespeed module](https://www.modpagespeed.com) of NGINX has been removed without replacement.

The [@ngx-translate/http-loader](https://github.com/ngx-translate/core) dependency was removed since we did not use it.
You might need to keep this dependency if you are loading translations differently from the standard Intershop PWA in your customization.

## 2.3 to 2.4

The PWA 2.4 contains an Angular update to version 13.3.10 and many other dependencies updates.
Expand Down
22 changes: 0 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"@nguniversal/express-engine": "13.1.1",
"@ngx-formly/core": "^5.12.3",
"@ngx-translate/core": "^14.0.0",
"@ngx-translate/http-loader": "^7.0.0",
"@rx-angular/state": "1.6.0",
"@sentry/browser": "^6.19.7",
"angular-oauth2-oidc": "13.0.1",
Expand Down

0 comments on commit 636a6e2

Please sign in to comment.