Fix merge group cancelling issue #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/fix-merge-group-cancelling-issue
branch
from
ba236aa
to
11040ff
Compare
erikd
approved these changes
Mar 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@newhoggy please make sure to keep notes about this in the knowledge base doc on merge queues. Under "common complications" with an analysis and solution. This won't be the last time we encounter this 😅 |
Jimbo4350
previously requested changes
Mar 9, 2023
|
The fact that we have to replicate this over so many files is a bit ... dissatisfying, it feels like this is going to easily lead to divergence? Do we need a GHA linter? |
angerman
reviewed
Mar 9, 2023
newhoggy
force-pushed
the
newhoggy/fix-merge-group-cancelling-issue
branch
from
11040ff
to
96c11be
Compare
Jimbo4350
approved these changes
Mar 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🙈 the replication everywhere. But let's fix that in a different Pr and get this merged to prevent unnecessary merge queue cancellations. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When more than one PR gets added the the merge queue, the earlier ones might cancel due to our concurrency policy. This is to prevent that.
See https://github.com/orgs/community/discussions/46757?sort=top#discussioncomment-4980818