Improve test output #4575
Merged
Improve test output #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/less-flaky-tests-2
branch
5 times, most recently
from
fe66fc5
to
68cf8be
Compare
newhoggy
requested review from
Jimbo4350,
a team,
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
|
Replaces #3596 |
newhoggy
force-pushed
the
newhoggy/less-flaky-tests-2
branch
from
68cf8be
to
41920b8
Compare
newhoggy
force-pushed
the
newhoggy/less-flaky-tests-2
branch
from
41920b8
to
6715b0b
Compare
Jimbo4350
reviewed
Oct 28, 2022
| import Data.Monoid (Last (..)) | ||
| import Data.Set (Set) | ||
| import qualified Data.Set as Set |
newhoggy
force-pushed
the
newhoggy/less-flaky-tests-2
branch
from
6715b0b
to
0ac5f32
Compare
newhoggy
force-pushed
the
newhoggy/less-flaky-tests-2
branch
from
0ac5f32
to
62198f6
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 28, 2022
4575: Improve test output r=newhoggy a=newhoggy Exceptions in tests (for example from partial functions) cause failure without line number which makes the cause difficult to find. This PR switches to use functions that accurately convey location of failure in the test. Use `byDeadlineM` instead of `assertByDeadlineM`, which allows specifying a period. This allows a longer poll time to be used so the test output isn't as spammy. Co-authored-by: John Ky <john.ky@iohk.io>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from CarlosLopezDeLara, JaredCorduan, Jimbo4350, LudvikGalois, dcoutts, erikd, and/or input-output-hk/devops.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Jimbo4350
approved these changes
Oct 29, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 29, 2022
4575: Improve test output r=Jimbo4350 a=newhoggy Exceptions in tests (for example from partial functions) cause failure without line number which makes the cause difficult to find. This PR switches to use functions that accurately convey location of failure in the test. Use `byDeadlineM` instead of `assertByDeadlineM`, which allows specifying a period. This allows a longer poll time to be used so the test output isn't as spammy. Co-authored-by: John Ky <john.ky@iohk.io>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
4575: Improve test output r=newhoggy a=newhoggy Exceptions in tests (for example from partial functions) cause failure without line number which makes the cause difficult to find. This PR switches to use functions that accurately convey location of failure in the test. Use `byDeadlineM` instead of `assertByDeadlineM`, which allows specifying a period. This allows a longer poll time to be used so the test output isn't as spammy. Co-authored-by: John Ky <john.ky@iohk.io>
newhoggy
force-pushed
the
newhoggy/less-flaky-tests-2
branch
from
62198f6
to
4ca121f
Compare
newhoggy
force-pushed
the
newhoggy/less-flaky-tests-2
branch
from
4ca121f
to
3f3a761
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions in tests (for example from partial functions) cause failure without line number which makes the cause difficult to find. This PR switches to use functions that accurately convey location of failure in the test.
Use
byDeadlineMinstead ofassertByDeadlineM, which allows specifying a period. This allows a longer poll time to be used so the test output isn't as spammy.