Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the workbench shell #4522

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix the workbench shell #4522

merged 1 commit into from
Oct 11, 2022

Conversation

michaelpj
Copy link
Contributor

Using cabalWrapped also requires us to mess with haskell.nix's choices for what packages to prepare the shell for.

Using `cabalWrapped` also requires us to mess with `haskell.nix`'s
choices for what packages to prepare the shell for.
@deepfire
Copy link
Contributor

deepfire commented Oct 11, 2022

Using cabalWrapped also requires us to mess with haskell.nix's choices for what packages to prepare the shell for.

To clarify, this is how it used to work, and that standard behavior was changed by 814b6d8#diff-65f4ca594d8a70559d53a677a686f5245807d0d094bbbb159e367766bf316ea2L81

..so I'm not sure where the mess with disparaging bit comes from.

Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @michaelpj for the fix!

@michaelpj
Copy link
Contributor Author

Yes, to be clear, I messed it up first!

@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 11, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit f5932ce into master Oct 11, 2022
@iohk-bors iohk-bors bot deleted the mpj/fix-workbench-shell branch October 11, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants