Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify sklearn explainer tests - part 2 #228

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Unify sklearn explainer tests - part 2 #228

wants to merge 12 commits into from
+273 −448

Conversation

gaugup
Copy link
Collaborator

@gaugup gaugup commented Sep 16, 2021

Signed-off-by: gaugup gaugup@microsoft.com

@gaugup
Unify sklearn explainer tests - part 2
6c94563 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup gaugup requested a review from amit-sharma September 16, 2021 07:32
@github-actions
Copy link

github-actions bot commented Sep 16, 2021 •
edited
Loading

Unit Test Results

0 files   -     1  0 suites   - 1   0s ⏱️ - 14m 16s
0 tests  - 221  0 ✔️  - 216  0 💤  - 5  0 ❌ ±0 

Results for commit f719519. ± Comparison against base commit bad94ac.

This pull request removes 221 tests. 
tests.test_counterfactual_explanations.TestCounterfactualExplanations ‑ test_sorted_local_importance_counterfactual_explanations
tests.test_counterfactual_explanations.TestCounterfactualExplanations ‑ test_sorted_summary_importance_counterfactual_explanations
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_counterfactual_explanations_output[0-2-1.0]
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_counterfactual_explanations_output[0-2-2.0]
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_empty_counterfactual_explanations_object[1.0]
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_empty_counterfactual_explanations_object[2.0]
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_local_importance_output[0-10-1.0]
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_local_importance_output[0-10-2.0]
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_no_counterfactuals_found[0-2-1.0]
tests.test_counterfactual_explanations.TestSerializationCounterfactualExplanations ‑ test_no_counterfactuals_found[0-2-2.0]
…

♻️ This comment has been updated with latest results.

@gaugup
Fix broken test
c205c3b 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Remove one more test
41da737 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Unify more tests
0975fe6 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Fix lint
d861178 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Fix failing test
29927c7 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Remove unused fixtures
5e06c34 
Signed-off-by: gaugup <gaugup@microsoft.com>
@amit-sharma
Copy link
Collaborator

one question: why is the test_dice_random.py file deleted? Is the idea that those tests are moved to explainer base?

@gaugup
Merge branch 'master' into gaugup/ContinueUnifyTest
3a9e1a9 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Merge branch 'master' into gaugup/ContinueUnifyTest
df9ee1e
@gaugup
Test fix
1b681d7 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Skipping test
e481e8b 
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Merge branch 'master' into gaugup/ContinueUnifyTest
f719519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-sharma amit-sharma Awaiting requested review from amit-sharma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaugup @amit-sharma