Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting.registrar_ip_whitelist_enabled setting is not respected on mobile-id login #976

Open
artur-intech opened this issue Sep 12, 2018 · 0 comments
Open

Setting.registrar_ip_whitelist_enabled setting is not respected on mobile-id login #976

artur-intech opened this issue Sep 12, 2018 · 0 comments

Comments

@artur-intech
Copy link
Contributor

artur-intech commented Sep 12, 2018 •
edited
Loading

User IP is checked even if Setting.registrar_ip_whitelist_enabled is false. It's not possible to login via m-ID if IP is not whitelisted (white_ips table).

registry/app/controllers/registrar/sessions_controller.rb

Line 114 in 0fef419

@user = find_user_by_idc_and_allowed(session[:user_id_code])

registry/app/controllers/registrar/sessions_controller.rb

Line 155 in 0fef419

if selected_user.registrar.white_ips.registrar_area.include_ip?(request.ip)

@artur-intech artur-intech changed the title User IP is checked even if Setting.registrar_ip_whitelist_enabled is false Setting.registrar_ip_whitelist_enabled setting is not respected on mobile-id login in registrar area Sep 12, 2018
@artur-intech artur-intech changed the title Setting.registrar_ip_whitelist_enabled setting is not respected on mobile-id login in registrar area Setting.registrar_ip_whitelist_enabled setting is not respected on mobile-id login Sep 12, 2018
@artur-intech artur-intech mentioned this issue Sep 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artur-intech