Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal error on operation caused by failure to send email #570

Open
vohmar opened this issue Jul 18, 2017 · 0 comments
Open

internal error on operation caused by failure to send email #570

vohmar opened this issue Jul 18, 2017 · 0 comments
Labels

Comments

@vohmar
Copy link
Contributor

vohmar commented Jul 18, 2017

In most cases failure to send email notification cannot be the reason to fail the request.
Returning unhandled internal error is a a bug

One such example is with cancelling pendingUpdate using admin interface when the domain is out of zone and registrant has email address under the same domain - unandled error is returned if the system is not able to send notification to the registrant about canceled pending Update request and the status is not removed (at the same time setting the pendingUpdate status does not fail for the same reason)

Only domain:update for registrant change and domain:delete requests should fail if sending the confirmation request to the current registrant fails.

On all other cases where the email is of informative nature - the operation it self and sending emails must be kept apart. The email sendig process is started after successful completion of the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant