You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using Registrar as a namespace for registrar area classes (for example Registrar::DeppController) is incorrect since it introduces constants under Registrar model class.
Same may apply to other areas.
Consider renaming registrar and registrant area namespaces to:
Distributor and Consumer
RegistrarArea and RegistrantArea
Other things to consider:
Route helpers length (should not be cumbersome to type)
The text was updated successfully, but these errors were encountered:
This becomes a real problem for further development.
Now this issue prevents refactoring registrar area controller hierarchy to use BaseController approach:
module Registrar
class BaseController < AdminController
end
end
The code above will not work because app/models/registrar.rb defines: class Registrar < ActiveRecord::Base.
Under some circumstances, defining class Registrar again will lead to exception, since the original class is derived from ActiveRecord::Base, whereas a new one is not.
registrar_contact_path is misleading. One can think (and I actually did before I realised an issue) of it as a contact of a registrar, whereas actually it points to a contact (registrant) in registrar area.
Using Registrar as a namespace for registrar area classes (for example Registrar::DeppController) is incorrect since it introduces constants under Registrar model class.
Same may apply to other areas.
Consider renaming registrar and registrant area namespaces to:
Other things to consider:
The text was updated successfully, but these errors were encountered: