Failure on sending an email notice makes the action fail

[vohmar]

Sending email notification must be handled separately from the action it self - the action should not depend on the success of sending an email. So the correct order of things should be take the action if action suceedes then try to send email.

example - removing pendingUpdate status on a domain failes because the system was unable to send email notification for that.

Dec 15 07:26:11 reg-l-epp ADMIN[26391]: Send RegistrantChangeMailer#notice email for domain domain-name-here.ee (#98765) to recepient@nxdomain.ee

Dec 15 13:50:21 reg-l-epp ADMIN[10736]: [reg-l-adm.infra] [17b58162-a225-4f82-9b5a-f9ac1dc78a0f] [192.168.2.45] #012AbstractController::ActionNotFound (The action 'show' could not be found for Admin::PendingUpdatesController):#012  config/initializers/eis_custom_flash.rb:9:in `call'

Dec 15 13:50:21 reg-l-epp ADMIN[10736]: [reg-l-adm.infra] [17b58162-a225-4f82-9b5a-f9ac1dc78a0f] [192.168.2.45] Started GET "/admin/domains/23826/pending_updates/23826" for 192.168.2.45 at 2016-12-15 13:50:21 +0200
Dec 15 13:50:21 reg-l-epp ADMIN[10736]: [reg-l-adm.infra] [17b58162-a225-4f82-9b5a-f9ac1dc78a0f] [192.168.2.45] #012AbstractController::ActionNotFound (The action 'show' could not be found for Admin::PendingUpdatesController):#012  config/initializers/eis_custom_flash.rb:9:in `call'

15 13:48:55 reg-l-epp ADMIN[10736]: [reg-l-adm.infra] [f9fe517a-88c1-432f-9e5d-ee672109ec3f] [172.16.249.7] #012Net::SMTPServerBusy (450 4.1.2 <recepient@nxdomain.ee>: Recipient address rejected: Domain not found#012):#012  app/jobs/domain_update_confirm_job.rb:21:in `block in run'#012  app/jobs/domain_update_confirm_job.rb:5:in `run'#012  app/models/registrant_verification.rb:25:in `domain_registrant_change_reject!'#012  app/controllers/admin/
pending_updates_controller.rb:17:in `destroy'#012  config/initializers/eis_custom_flash.rb:9:in `call'

15 13:48:55 reg-l-epp ADMIN[10736]: [reg-l-adm.infra] [f9fe517a-88c1-432f-9e5d-ee672109ec3f] [172.16.249.7] #012Sent mail to recepient@nxdomain.ee (128.3ms)
Dec 15 13:48:55 reg-l-epp ADMIN[10736]: [reg-l-adm.infra] [f9fe517a-88c1-432f-9e5d-ee672109ec3f] [172.16.249.7] Completed 500 Internal Server Error in 523ms (ActiveRecord: 8.1ms)
Dec 15 13:48:55 reg-l-epp ADMIN[10736]: [reg-l-adm.infra] [f9fe517a-88c1-432f-9e5d-ee672109ec3f] [172.16.249.7] #012Net::SMTPServerBusy (450 4.1.2 <recepient@nxdomain.ee>: Recipient address rejected: Domain not found#012):#012  app/jobs/domain_update_confirm_job.rb:21:in `block in run'#012  app/jobs/domain_update_confirm_job.rb:5:in `run'#012  app/models/registrant_verification.rb:25:in `domain_registrant_change_reject!'#012  app/controllers/admin/
pending_updates_controller.rb:17:in `destroy'#012  config/initializers/eis_custom_flash.rb:9:in `call'