Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting test coverage threshold in Travis CI #1536

Open
yulgolem opened this issue Feb 20, 2020 · 3 comments
Open

Consider setting test coverage threshold in Travis CI #1536

yulgolem opened this issue Feb 20, 2020 · 3 comments

Comments

@yulgolem
Copy link
Contributor

ATM we do not have test coverage threshold set in Travis, and current master coverage level is about 60%.
Maybe we should pump the coverage level and set the ci threshold for this, like in auction app?

@vohmar , @karlerikounapuu your opinion?

@vohmar
Copy link
Contributor

vohmar commented Feb 20, 2020

agreed, but feel like a lot of work to bump this overage upto a decent level. Any suggestions what the level should be?

@yulgolem
Copy link
Contributor Author

Well, on one hand assuming our goal is not to set restrictions, but to get max coverage... and on other hand there are some functionality that might be hard to test fully without integration (e.g. registrar portal etc), I suppose maybe we might just dedicate, say, a day per couple of weeks just to pump the tests quantity/quality.
And, I suppose, total coverage threshold might be the current 60% per start, 70%-75% in progress up to 90% ideally.

@karlerikounapuu
Copy link
Member

karlerikounapuu commented Feb 21, 2020

In overall, I agree with setting higher coverage threshold. But in my opinion it doesn't resolve any issues we have at the moment, most (if not all) of the PR-s we are pushing are 95%+ cov anyways.

To me, it doesn't really feel right to write tests for functionality I'm not 100% familiar with which renders tests written pretty useless. Yup, we might be able to push coverage visually, but that isn't a point actually. We can give it a try though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants