-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade paper_trail to Rails 5.x/6.X compatible version #1288
Comments
Our current version (4.2.0) already supports all Rails versions prior to 6 (https://github.com/paper-trail-gem/paper_trail/blob/v4.2.0/paper_trail.gemspec#L22). Done in #1094. So it actually doesn't block #377. |
@artur-beljajev paper-trail-gem/paper_trail#689 was fixed in papertrail 5.x aswell there are some other rails 5.x related fixes in papeptrail 5.x but if you are certain they wont affect us keep close this ticket / remove the blocking comment . |
I have reviewed the PR in question. There is indeed Rails 5.0 compatibility change, but it only concerns reifying So at least based on above mentioned gemspec, I guess it's safe to assume that currently used version (4.2.x) still supports Rails to some decent extent. In the worst case some info will be unavailable in UI, but nothing harmful should happen in terms of versioning and data. Thanks for pointing out! |
@artur-beljajev |
Solves what? :) I think it's safe enough to go with Rails 5.0 upgrade with the current version of I don't think we need separate ticket for every gem update in this particular case. |
We need to upgrade paper_trails to more modern version so we can upgrade Rails and Ruby.
This upgrade surely introduces many breaking changes to our code and will involve big effort in verifying end result, but according to #536 we don't have good alternative solution.
Some of the effort is already documented in #426 but surely there is more.
4.2.0 Current version
Currently this issue is blocking #377
The text was updated successfully, but these errors were encountered: