Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon docker images #471

Open
ziodave opened this issue Mar 13, 2022 · 1 comment
Open

Apple Silicon docker images #471

ziodave opened this issue Mar 13, 2022 · 1 comment

Comments

@ziodave
Copy link

ziodave commented Mar 13, 2022

It looks the docker archive at https://hub.docker.com/r/iipc/heritrix is missing the Apple Silicon images:

$ docker run --init --rm -d -p 8443:8443 -e "USERNAME=admin" -e "PASSWORD=admin" -v $(pwd)/jobs:/opt/heritrix/jobs iipc/heritrix                                                              ✘ 125
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

I'll see if I can make a contribution.

@ziodave
Copy link
Author

ziodave commented Mar 13, 2022

This would be the updated GH action file: https://github.com/ziodave/heritrix3/blob/master/.github/workflows/docker-image.yml

Example multi-arch image is here: https://github.com/ziodave/heritrix3/pkgs/container/heritrix3

The registry, username and password would need to be updated accordingly. Right now they're using respectively env.REGISTRY, github.actor and secrets.GITHUB_TOKEN.

Let me know if you want me to create a PR.

I also suggest to enhance it further so that it can automatically create production images when a new tag is created, for reference see https://docs.github.com/en/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions#upgrading-a-workflow-that-accesses-ghcrio and https://github.com/docker/metadata-action).

I can contribute that too if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants