Add Arista to Global Reactor

In order to run the compliance tests

Author: Stephane Robert

constraints.txt

@@ -4,23 +4,24 @@
 #
 #    pip-compile --no-index --no-emit-trusted-host --output-file constraints.txt requirements.txt
 #
-certifi==2018.8.24        # via requests
+certifi==2018.10.15       # via requests
 chardet==3.0.4            # via requests
-click==6.7                # via flask
+click==7.0                # via flask
 ecdsa==0.13               # via paramiko
 flask==1.0.2
 idna==2.7                 # via requests
 itsdangerous==0.24        # via flask
 jinja2==2.10              # via flask
-lxml==4.2.4               # via ncclient
+lxml==4.2.5               # via ncclient
 markupsafe==1.0           # via jinja2
-ncclient==0.6.2
+ncclient==0.6.3
 netaddr==0.7.19
 paramiko==1.17.6
-pbr==4.2.0
+pbr==5.0.0
 pycrypto==2.6.1           # via paramiko
-requests==2.19.1
+pyeapi==0.8.2
+requests==2.20.0
 selectors2==2.0.1         # via ncclient
 six==1.11.0               # via ncclient
-urllib3==1.23             # via requests
+urllib3==1.24             # via requests
 werkzeug==0.14.1          # via flask

netman/adapters/switches/arista.py

@@ -9,6 +9,10 @@
 from netman.core.objects.vlan import Vlan
 
 
+def eapi(switch_descriptor):
+    return Arista(switch_descriptor=switch_descriptor)
+
+
 class Arista(SwitchBase):
     def __init__(self, switch_descriptor):
         super(Arista, self).__init__(switch_descriptor)

netman/core/switch_factory.py

@@ -12,13 +12,14 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from netman.adapters.switches import cisco, juniper, dell, dell10g, brocade
+from netman.adapters.switches import cisco, juniper, dell, dell10g, brocade, arista
 from netman.adapters.switches.juniper.mx import netconf as mx_netconf
 from netman.adapters.switches.remote import RemoteSwitch
 from netman.core.objects.flow_control_switch import FlowControlSwitch
 from netman.core.objects.switch_descriptor import SwitchDescriptor
 
 factories = {
+    "arista": arista.eapi,
     "cisco": cisco.ssh,
     "brocade": brocade.ssh,
     "brocade_ssh": brocade.ssh,

test-constraints.txt

@@ -4,24 +4,24 @@
 #
 #    pip-compile --no-index --no-emit-trusted-host --output-file test-constraints.txt test-requirements.txt constraints.txt rtd-requirements.txt
 #
-alabaster==0.7.11         # via sphinx
+alabaster==0.7.12         # via sphinx
 appdirs==1.4.3            # via rply, twisted
 args==0.1.0               # via clint
 asn1crypto==0.24.0        # via cryptography
 astor==0.7.1              # via hy
 babel==2.6.0              # via sphinx
-certifi==2018.8.24
+certifi==2018.10.15
 cffi==1.11.5              # via cryptography
 chardet==3.0.4
-click==6.7
+click==7.0
 clint==0.5.1              # via hy
 configparser==3.5.0       # via flake8
 constantly==15.1.0        # via twisted
 cryptography==2.3.1       # via twisted
 docutils==0.14            # via sphinx
 ecdsa==0.13
 enum34==1.1.6             # via cryptography, flake8
-fake-switches==1.2.5
+fake-switches==1.3.0
 flake8==3.4.1
 flask==1.0.2
 flexmock==0.10.2
@@ -35,34 +35,36 @@ imagesize==1.1.0          # via sphinx
 incremental==17.5.0       # via twisted
 ipaddress==1.0.22         # via cryptography
 itsdangerous==0.24
+jabstract==0.1.2
 jinja2==2.10
-lxml==4.2.4
+lxml==4.2.5
 markupsafe==1.0
 mccabe==0.6.1             # via flake8
 mock==2.0.0
 mockssh==1.4.3
-ncclient==0.6.2
+ncclient==0.6.3
 netaddr==0.7.19
 nose==1.3.7
 paramiko==1.17.6
-pbr==4.2.0
+pbr==5.0.0
 pyasn1==0.4.4             # via mockssh, twisted
 pycodestyle==2.3.1        # via flake8
-pycparser==2.18           # via cffi
+pycparser==2.19           # via cffi
 pycrypto==2.6.1
+pyeapi==0.8.2
 pyflakes==1.5.0           # via flake8
 pygments==2.2.0           # via sphinx
 pyhamcrest==1.9.0
 pytz==2018.5              # via babel
-requests==2.19.1
+requests==2.20.0
 rply==0.7.6               # via hy
 selectors2==2.0.1
 six==1.11.0
 snowballstemmer==1.2.1    # via sphinx
 sphinx==1.5.6
 sphinxcontrib-httpdomain==1.7.0
-tftpy==0.7.0              # via fake-switches
+tftpy==0.8.0              # via fake-switches
 twisted[conch]==16.6.0    # via fake-switches, mockssh
-urllib3==1.23
+urllib3==1.24
 werkzeug==0.14.1
 zope.interface==4.5.0     # via twisted

tests/adapters/compliance_tests/add_vlan_test.py

@@ -21,7 +21,7 @@
 
 
 class AddVlanTest(ComplianceTestCase):
-    _dev_sample = "juniper_qfx_copper"
+    _dev_sample = "arista"
 
     def test_creates_an_empty_vlan(self):
         self.client.add_vlan(1000)

tests/adapters/model_list.py

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+from fake_switches.arista.arista_core import AristaSwitchCore
 from fake_switches.brocade.brocade_core import BrocadeSwitchCore
 from fake_switches.cisco.cisco_core import CiscoSwitchCore
 from fake_switches.cisco6500.cisco_core import Cisco6500SwitchCore
@@ -20,12 +21,31 @@
 from fake_switches.juniper.juniper_core import JuniperSwitchCore
 from fake_switches.juniper_mx.juniper_mx_core import JuniperMXSwitchCore
 from fake_switches.juniper_qfx_copper.juniper_qfx_copper_core import JuniperQfxCopperSwitchCore
-from fake_switches.ssh_service import SwitchSshService
+from fake_switches.transports.ssh_service import SwitchSshService
 from fake_switches.switch_configuration import Port, AggregatedPort
-from fake_switches.telnet_service import SwitchTelnetService
+from fake_switches.transports.telnet_service import SwitchTelnetService
+from fake_switches.transports.http_service import SwitchHttpService
+
 from netman.core.objects.switch_descriptor import SwitchDescriptor
 
 available_models = [
+    {
+        "switch_descriptor": SwitchDescriptor(
+            model="arista",
+            hostname="127.0.0.1",
+            port=11015,
+            username="root",
+            password="root",
+        ),
+        "test_port_name": "Ethernet1",
+        "test_vrrp_track_id": "",
+        "core_class": AristaSwitchCore,
+        "service_class": SwitchHttpService,
+        "ports": [
+            Port("Ethernet1"),
+            Port("Ethernet2"),
+        ]
+    },
     {
         "switch_descriptor": SwitchDescriptor(
             model="cisco",

tests/adapters/unified_tests/bond_management_test.py

@@ -21,7 +21,7 @@
 class BondManagementTest(ConfiguredTestCase):
     __test__ = False
 
-    @skip_on_switches("cisco", "brocade", "brocade_telnet", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx")
+    @skip_on_switches("cisco", "brocade", "brocade_telnet", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx", "arista")
     def test_creating_deleting_a_bond(self):
         self.client.add_bond(3)
 

tests/adapters/unified_tests/dhcp_relay_server_test.py

@@ -21,7 +21,7 @@
 class DhcpRelayServerTest(ConfiguredTestCase):
     __test__ = False
 
-    @skip_on_switches("juniper", "juniper_qfx_copper", "juniper_mx", "dell", "dell_telnet", "dell10g", "dell10g_telnet")
+    @skip_on_switches("juniper", "juniper_qfx_copper", "juniper_mx", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "arista")
     def test_add_and_get_and_delete_dhcp_relay_server(self):
         try:
             self.client.add_vlan(2999, name="my-test-vlan")

tests/adapters/unified_tests/interface_management_test.py

@@ -18,22 +18,22 @@
 class InterfaceManagementTest(ConfiguredTestCase):
     __test__ = False
 
-    @skip_on_switches("juniper", "juniper_qfx_copper", "juniper_mx")
+    @skip_on_switches("juniper", "juniper_qfx_copper", "juniper_mx", "arista")
     def test_set_interface_state_off(self):
         self.client.set_interface_state(self.test_port, OFF)
 
-    @skip_on_switches("juniper", "juniper_qfx_copper", "juniper_mx")
+    @skip_on_switches("juniper", "juniper_qfx_copper", "juniper_mx", "arista")
     def test_set_interface_state_on(self):
         self.client.set_interface_state(self.test_port, ON)
 
-    @skip_on_switches("cisco", "brocade", "brocade_telnet", "juniper_mx")
+    @skip_on_switches("cisco", "brocade", "brocade_telnet", "juniper_mx", "arista")
     def test_edit_spanning_tree(self):
         self.client.edit_interface_spanning_tree(self.test_port, edge=True)
 
-    @skip_on_switches("cisco", "brocade", "brocade_telnet", "juniper_mx")
+    @skip_on_switches("cisco", "brocade", "brocade_telnet", "juniper_mx", "arista")
     def test_set_interface_lldp_state(self):
         self.client.set_interface_lldp_state(self.test_port, enabled=True)
 
-    @skip_on_switches("cisco", "brocade", "brocade_telnet", "juniper_mx")
+    @skip_on_switches("cisco", "brocade", "brocade_telnet", "juniper_mx", "arista")
     def test_disable_lldp(self):
         self.client.set_interface_lldp_state(self.test_port, enabled=False)

tests/adapters/unified_tests/ip_management_test.py

@@ -25,7 +25,7 @@
 class IpManagementTest(ConfiguredTestCase):
     __test__ = False
 
-    @skip_on_switches("juniper", "juniper_qfx_copper", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx")
+    @skip_on_switches("juniper", "juniper_qfx_copper", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx", "arista")
     def test_adding_and_removing_ip_basic(self):
         self.client.add_vlan(2345)
 
@@ -58,7 +58,7 @@ def test_adding_and_removing_ip_basic(self):
 
         self.client.remove_vlan(2345)
 
-    @skip_on_switches("juniper", "juniper_qfx_copper", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx")
+    @skip_on_switches("juniper", "juniper_qfx_copper", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx", "arista")
     def test_adding_unavailable_ips_and_various_errors(self):
         self.client.add_vlan(2345)
 
@@ -91,7 +91,7 @@ def test_adding_unavailable_ips_and_various_errors(self):
 
         self.client.remove_vlan(2345)
 
-    @skip_on_switches("juniper", "juniper_qfx_copper", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx")
+    @skip_on_switches("juniper", "juniper_qfx_copper", "dell", "dell_telnet", "dell10g", "dell10g_telnet", "juniper_mx", "arista")
     def test_handling_access_groups(self):
         self.client.add_vlan(2345)