fix(backend): update minSendAmount in local and ILP payments #3480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
minSendAmountin local payments when we pass in a 0 debit amount to the quoteContext
When testing the minSendAmount feature, I found a few cases where we needed to update the logic:
highEstimatedExchangeRatereciprocal calculation of something likeSince this results in 1 minimum send amount, we return 1.
However, this will still end up causing an issue, since ILP pay will subtract at least 1 unit of value from the receiving account to make up for potential flooring loss, meaning that if we send 1 unit, we will still get 0 as the expected delivery amount:
This means we always need to send at least 2 units of value from the sender.
Related to #3353, RAF-998
Checklist
fixes #numberuser-docslabel (if necessary)