Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require knex transaction where expected #618

Open
wilsonianb opened this issue Sep 20, 2022 · 1 comment
Open

Require knex transaction where expected #618

wilsonianb opened this issue Sep 20, 2022 · 1 comment
Labels
good first issue Good for newcomers hacktoberfest pkg: backend Changes in the backend package. tech debt Areas which require refactor and clean up
Milestone
Tech Debt

Comments

@wilsonianb
Copy link
Contributor

wilsonianb commented Sep 20, 2022 •
edited by mkurapov
Loading

When a function is expecting a trx?: TransactionOrKnex as a parameter, we should change the type to be specifically Transaction instead.
@wilsonianb wilsonianb added the pkg: backend Changes in the backend package. label Sep 20, 2022
@wilsonianb wilsonianb mentioned this issue Sep 20, 2022
Merged
4 tasks
@wilsonianb wilsonianb added the good first issue Good for newcomers label Oct 3, 2022
@sabineschaller sabineschaller added this to the Tech Debt milestone Mar 29, 2023
@Urva2
Copy link

Urva2 commented Oct 28, 2023

i want to work on this issue.

@mkurapov mkurapov added tech debt Areas which require refactor and clean up stale and removed good first issue Good for newcomers labels Mar 4, 2024
@mkurapov mkurapov added good first issue Good for newcomers hacktoberfest and removed stale labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest pkg: backend Changes in the backend package. tech debt Areas which require refactor and clean up
Projects
Rafiki
Status: Backlog
Rafiki
Status: No status
Milestone
Tech Debt
Development

No branches or pull requests
4 participants
@wilsonianb @mkurapov @sabineschaller @Urva2